D13717: Implement Seek() and Seeked()

[Adam Mokhtari]

mokhtari added a comment.


  Regarding loops with the Media Player widget, I haven't noticed any (using KDE Neon, 5.13.1). What test would catch this?

INLINE COMMENTS

> broulik wrote in content-script.js:177
> The `seekable` property isn't an int but a `TimeRanges` object that tells you which portions of the player are seekable so this will never be `false`
> 
> [1] https://www.w3schools.com/tags/av_prop_seekable.asp

Good catch. I uploaded a fix for this.

> broulik wrote in mprisplugin.cpp:205
> Can't you just do `emit Seeked(position)`?

MPrisPlugin doesn't define Seeked, so no. But it's fine with me if you think adding it to the parent and using the signal auto-relaying would be better.

Regarding macros vs. keywords, I just figured macros would be more compatible, but it could be switched to using emit as well.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13717

To: mokhtari, broulik
Cc: nicolasfella, plasma-devel, #kde_connect, timothyc, jdvr, yannux, Danial0_0, johnq, ragreen, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, ZrenBot, seebauer, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, jensreuterberg, ach, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180628/d926cefa/attachment.html>