D13760: [Media Frame] Fix history length property

David Faure noreply at phabricator.kde.org
Wed Jun 27 14:12:09 UTC 2018


dfaure added inline comments.

INLINE COMMENTS

> davidedmundson wrote in mediaframe.cpp:336
> This could have just been an else of the branch above

And then one day someone adds a check for contains() before prepend(), for instance, and you would need to come back to this structure of the code. So this is more flexible.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13760

To: broulik, #plasma, dfaure, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180627/cd862ec2/attachment.html>


More information about the Plasma-devel mailing list