D13679: Fix recent toolbar layout regression

Marco Martin noreply at phabricator.kde.org
Wed Jun 27 09:50:55 UTC 2018


mart added a comment.


  In D13679#283361 <https://phabricator.kde.org/D13679#283361>, @ngraham wrote:
  
  > Aleix implemented a better version of this with https://cgit.kde.org/discover.git/commit/?id=d5f7c102854c41e4ee9eb00cfb979993f2396233
  
  
  I'm still not sure about it.
  is it supposed to switch to breadcrumb when the window is narrow? (and buttons as fab on the bottom) in kirigami desktop apps are supposed to always have the top toolbar, even when they are narrow, that's why it gets navigation buttons, even when they are in tablet mode: bottom action buttons are purely for reachability in single hand mode on phones.
  
  Note that this has nothing to do with plasma mobile, there it would always be in breadcrumb+fab mode (you can test its behavior on desktop with export QT_QUICK_CONTROLS_MOBILE=1)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13679

To: ngraham, #discover_software_store
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180627/24ccad1c/attachment.html>


More information about the Plasma-devel mailing list