D13679: Fix recent toolbar layout regression

Nathaniel Graham noreply at phabricator.kde.org
Fri Jun 22 13:44:47 UTC 2018


ngraham created this revision.
ngraham added a reviewer: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  D13663 <https://phabricator.kde.org/D13663> fixed the issue, so let's use it and then bump the required Kirigami frameworks version
  
  BUG: 395455
  Depends on D13663 <https://phabricator.kde.org/D13663>

TEST PLAN
  Fixes that regression, but seems to introduce a new one:
  F5932887: Unnecessary whitespace.png <https://phabricator.kde.org/F5932887>
  
  Unclear whether this is a Discover issue or related to D13663 <https://phabricator.kde.org/D13663>

REPOSITORY
  R134 Discover Software Store

BRANCH
  fix-toolbar-layout-regression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13679

AFFECTED FILES
  CMakeLists.txt
  discover/qml/DiscoverWindow.qml

To: ngraham, #discover_software_store
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180622/e274bc29/attachment-0001.html>


More information about the Plasma-devel mailing list