D13628: Make content-script media player code follow user settings

David Edmundson noreply at phabricator.kde.org
Wed Jun 20 11:10:29 UTC 2018


davidedmundson created this revision.
davidedmundson added reviewers: fvogt, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If a user disables the mpris plugin there's no point loading anything in
  the client page.
  
  Also split the mediaSessions shim into a separate option as it's much
  more invasive than the regular mpris controls.
  
  For now the latter is disabled by default. It breaks some sites, we
  can't afford to do that and we need to put a fix for that immediately.
  
  We can revisit it later.

TEST PLAN
  Ran media-sessions API page
  With extended mpris on I got thumbnails
  With it off I still had the classic video control

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13628

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/constants.js
  extension/content-script.js
  extension/options.html

To: davidedmundson, fvogt, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180620/720304c2/attachment-0001.html>


More information about the Plasma-devel mailing list