D13623: [kded kcm] Fix estimating dbusModuleName of kded plugins

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: dfaure, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The entry X-KDE-DBus-ModuleName has never been used by kded code,
  at least is using it these days, so the check for that metadata entry
  and using its value is broken.
  
  Instead Kded::loadModule() used KPluginMetaData::pluginId() to set the
  module name, which then is used by KDEDModule for its D-Bus object path.
  
  The branch for handling an empty name is removed as that fallback is
  covered by KPluginMetaData already.

TEST PLAN
  KCM now lists all kded plugins, no longer complains about modules it could not
  relate.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixkdedkcmdbusmodulenames

REVISION DETAIL
  https://phabricator.kde.org/D13623

AFFECTED FILES
  kcms/kded/kcmkded.cpp

To: kossebau, dfaure, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180619/44b422c2/attachment.html>