D13612: Fix drop between shared views

Robert Hoffmann noreply at phabricator.kde.org
Tue Jun 19 15:10:01 UTC 2018


hoffmannrobert created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  Remove trailing slash from folderUrl, too, when comparing to
  the file's url (minus file name minus trailing slash). FolderUrls
  like file:///home/user/Desktop/ may appear and fail comparing.
  
  Fixes regression introduced in 07001277a8a0893aeb54240d7f5cdd9825fb57ed <https://phabricator.kde.org/R119:07001277a8a0893aeb54240d7f5cdd9825fb57ed>
  (see https://phabricator.kde.org/D10729) which fixes urls like
  file:///home/user/foo (if using a different folder than Desktop)
  but breaks moving files from one screen to another using normal
  Desktop folder.

TEST PLAN
  1. Use folder view, Desktop folder, more than one screen.
  
  Create files and folders in Desktop folder and move them from one
  screen to another. The Copy/Move/Link menu must not appear
  and files/folders must be dropped onto the other screen.
  
  2. Use a different folder than Desktop (the same on both screens).
  
  Moving files/folders to another screen must work like in 1.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13612

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: hoffmannrobert
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180619/e3781f4f/attachment-0001.html>


More information about the Plasma-devel mailing list