D13360: Touchpad KDED module: Convert to JSON metadata

[Friedrich W. H. Kossebau]

kossebau added a comment.


  This patch seems to have broken things ("kcm does not load") by what people reported in irc for 5.13.1.
  
  By a quick investigation the main reason is, that the old plugin binary with the name "kded_touchpad" is used both to provide the plugin for kcm as well as the plugin for the kded.
  See how both plugins had been registered for the TouchpadPluginFactory in the removed file plugins.cpp, with two plugin metadata desktop files referencing the very plugin "kded_touchpad" to find their repective plugin (the second via the "kcm" id): kcm_touchpad.desktop and kded_touchpad.desktop
  
  By turning the actual plugin into the new-style "embedded json in custom path" type plugin, the plugin metadata for the kcm plugin is now pointing into the void, as both the name is now wrong as well is the plugin no longer in the common plugin dir, but in a subdir (not sure if kcm plugins are searched also in subdirs).
  
  No idea where the actual bug this patch was supposed to fix is coming from, but it has broken things in a different way :)
  
  One solution might be to properly split the current single plugin binary into 2 separate plugin binaries, one per kcm and one per kded plugin, and add a shared private lib for the stuff they might share.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

To: marten, #plasma, davidedmundson
Cc: kossebau, fvogt, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180619/86cd941f/attachment.html>