D13255: Make dependency on KF5NetworkManagerQt optional

Ivan Čukić noreply at phabricator.kde.org
Sat Jun 9 20:02:52 UTC 2018


ivan added a comment.


  Very nice, thanks. If you want I can accept this (after the `Q_UNUSED` change) and I'll do the UI patch separately.

INLINE COMMENTS

> service.cpp:53
> +    {
> +        (void)enabled;
> +    }

You should use `Q_UNUSED` instead.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D13255

To: asturmlechner, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180609/a9a9904d/attachment-0001.html>


More information about the Plasma-devel mailing list