D13112: Port Plasma Desktop Scripting to QJSEngine

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  +++++
  Thanks for tackling a very boring and difficult task.
  
  There are two things I'd like to see also tested:
  
  - the DBus wallpaper changing script that I know a bunch of people use
  - Something using executeSetupPlasmoidScript

INLINE COMMENTS

> scriptengine_v1.cpp:198
> +    if (param.isUndefined()) {
> +        return m_engine->evaluate(QString("new Error('%1');").arg(i18n("activityForScreen requires a screen id")));
>      }

I think we should add a wrapper for this error creation in ScriptEngine, it's duplicated a lot.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/QJSEngineScripting

REVISION DETAIL
  https://phabricator.kde.org/D13112

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180607/c128e8eb/attachment.html>