D13202: Circular user avatar for Kickoff

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> Header.qml:104
> +            //but in SDDM that's a bit pointless
> +            fragmentShader: "
> +                            varying highp vec2 qt_TexCoord0;

I tried using fragment shader in discover and it ported poorly on different hardware. Maybe OpacityMask or Rectangle + clip works too.

> sharvey wrote in Header.qml:139
> Was `faceIcon.status !== Image.Ready`, which I believe was an old timing test when machines were slower. Doesn't seem necessary on modern hardware.

No need to set it to true, just drop the line.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13202

To: sharvey, ngraham, hein, #plasma
Cc: apol, davidedmundson, plasma-devel, abetts, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180605/04851ec0/attachment.html>