D13360: Touchpad KDED module: Convert to JSON metadata

[Jonathan Marten]

marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
marten requested review of this revision.

REVISION SUMMARY
  This is now the preferred way of providing plugin metadata.  It's not just a cosmetic change because there is an actual problem with the original:  the desktop file kded_touchpad.desktop sets X-KDE-DBus-ModuleName=touchpad which is presumably intended to register the KDED module under that name on DBus;  all of the clients access it with the interface path "/modules/touchpad".  However, this key appears to be being ignored, and the module is registered under the path "/modules/kded_touchpad" which can be confirmed with qdbusviewer.  This incorrect path means that touchpad control via the Plasma applet does not work, and 'kcmshell5 kcmkded' does not show the touchpad module status correctly.
  
  This change updates the KDED plugin to use JSON metadata.

TEST PLAN
  Built plasma-desktop with this change.  Observed correct registration of the module name on DBus, correct operation of the Plasma touchpad applet, and of "kcmshell5 kcmkded" and "kcmshell5 kcm_touchpad".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13360

AFFECTED FILES
  kcms/touchpad/src/CMakeLists.txt
  kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/src/kded/kded.cpp
  kcms/touchpad/src/kded/kdedactions.cpp
  kcms/touchpad/src/plugins.cpp
  kcms/touchpad/src/plugins.h

To: marten, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180605/c42f300e/attachment.html>