D13141: Touchpad KCM Redesign Using Kirigami

[Roman Gilg]

romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.qml:101
> +            enabled: touchpadCount > 1
> +            visible: touchpadCount > 1 // Invisible if there is only 1 touchpad device
> +            Layouts.Layout.fillWidth: true

I'm against this change for several reasons:

- In general control elements shouldn't be completely hidden but only disabled to improve discoverability of features.
- When a user has the KCM open and he connects a second touchpad or removes the first one the whole Ui shifts down/up.
- While being greyed out the combobox still shows the current device name in case there is only one connected and therefore gives valuable information to the user.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13141

To: furkantokac, ngraham, romangg, abetts
Cc: esedgh, knambiar, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180604/2bcc5093/attachment.html>