D14493: fontinst quits after KJob is done

David Faure noreply at phabricator.kde.org
Tue Jul 31 09:52:53 BST 2018


dfaure added a comment.


  The idea of KJob reference-counting the event loop is that if you quit the application while a kjob is executing, then the process will wait for the job to finish before quitting. (Use case back then, konqueror and a HTTP download).
  The reason why we don't just quit after the first job is that KMainWindow itself uses QEventLoopLocker too, increasing the refcount as long as there are visible windows.
  
  If kfontinst has no way to quit while a job is happening, this patch is ok.
  But maybe it would be better to create a QEventLoopLocker in whichever GUI class kfontinst creates?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14493

To: mathiastillman, #plasma, dfaure, aacid, gateau
Cc: wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180731/ea56fdde/attachment-0001.html>


More information about the Plasma-devel mailing list