D14476: QMLScreen: do not declare the engine a member

Frederik Gladhorn noreply at phabricator.kde.org
Mon Jul 30 08:42:04 BST 2018


gladhorn added inline comments.

INLINE COMMENTS

> broulik wrote in qmlscreen.h:109
> This entire custom engine handling could be removed, with `QMLScreen` using `qmlEngine(this)` when creating an `QMLOutput`

I had briefly tried and got a nullptr from qmlEngine, but I didn't really spend time on it.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14476

To: gladhorn, #plasma, romangg
Cc: broulik, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180730/4424cc27/attachment-0001.html>


More information about the Plasma-devel mailing list