D14050: Fwupd Backend For Review and Improvement

[Aleix Pol Gonzalez]

apol added a comment.


  Please, do some review yourself, you should be able to see most of these things yourself

INLINE COMMENTS

> FwupdSourcesBackend.cpp:151
> +{
> +    return  m_actions ;
> +}

`return {}` and remove the unused attribute.

> FwupdSourcesBackend.h:46
> +    bool supportsAdding() const override { return false; }
> +    void eulaRequired(const QString& remoteName , const QString& licenseAgreement);
> +    void populateSources();

There's no space before a coma.

> FwupdSourcesBackend.h:54
> +    FwupdSourcesModel* m_sources;
> +    QList<QAction*> m_actions;
> +};

Remove.

> FwupdTransaction.cpp:99
> +        QNetworkAccessManager *manager = new QNetworkAccessManager(this);
> +        connect(manager, SIGNAL(finished(QNetworkReply*)),this, SLOT(fwupdInstall(QNetworkReply*)));
> +        manager->get(QNetworkRequest(uri));

Use proper connect syntax.

> FwupdTransaction.cpp:160
> +
> +void FwupdTransaction::iterateTransaction()
> +{

Give it a name that says what it does, this is just copied from the dummy and thus it has a meaningless name.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D14050

To: abhijeet2096, apol, davidedmundson
Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180729/b13c86c9/attachment-0001.html>