D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

David Faure noreply at phabricator.kde.org
Sat Jul 28 13:30:14 BST 2018


dfaure created this revision.
dfaure added reviewers: arichardson, anthonyfieroni, elvisangelaccio, plasma-devel, broulik.
dfaure requested review of this revision.

REVISION SUMMARY
  This was fixed initially in commit 7bbbd93 <https://phabricator.kde.org/R135:7bbbd93cd3fc0abdffd3fa7f144cb50a33fafad9> (https://phabricator.kde.org/D3796)
  when the unittest was added, and broken later in commit bfd41a9 <https://phabricator.kde.org/R135:bfd41a95530f90ee8d44cbcfd1fa8c62978334a2>
  (https://phabricator.kde.org/D4193, bug 374913) which says Qt takes care
  of taking the initial directory when calling selectUrl(). I cannot see
  that in the Qt code, where selectUrl only calls selectFile_sys.
  
  This breaks bug 374913 again (initial directory for remote files), but the
  right fix for that is https://codereview.qt-project.org/235473

TEST PLAN
  unittest

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D14440

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp
  src/platformtheme/kdeplatformfiledialoghelper.h

To: dfaure, arichardson, anthonyfieroni, elvisangelaccio, plasma-devel, broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180728/63091e92/attachment.html>


More information about the Plasma-devel mailing list