D14437: Fix QFileDialog not remembering the last visited directory.

David Faure noreply at phabricator.kde.org
Sat Jul 28 12:27:52 BST 2018


dfaure created this revision.
dfaure added reviewers: anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson.
Restricted Application added a project: Plasma.
dfaure requested review of this revision.

REVISION SUMMARY
  This regression (compared to kdelibs4's direct KFileDialog usage) came
  from the fact that QFileDialog's lastVisited() only gets updated if
  the helper emits directoryEntered.
  
  So QFileDialog was setting the current dir as startDir every single
  time, overriding's KFileWidget's own logic for reusing the last dir
  initially.

TEST PLAN
  QFileDialog::getOpenFileName(this, i18n("Select file"));
  twice in a row, from the same process.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D14437

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: dfaure, anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson
Cc: ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180728/1768d2a7/attachment.html>


More information about the Plasma-devel mailing list