D14364: Test configId in TestSerializer
Roman Gilg
noreply at phabricator.kde.org
Fri Jul 27 09:48:42 BST 2018
romangg added inline comments.
INLINE COMMENTS
> serializertest.cpp:163
> + auto configId = QLatin1String("8684e883209d7644eb76feea2081c431");
> + QCOMPARE(Serializer::configId(config), configId);
> +
Below we do some tests in regards to the current config id value. These tests are unrelated to any changes of the config id value over time. Therefore it should not reference the magic config id value.
Replace the above two lines with:
auto configId = Serializer::configId(config);
// check that this config id value is unchanged from previous versions of this software
QCOMPARE(configId, QLatin1String("8684e883209d7644eb76feea2081c431");
Rest below unchanged in this function. Same in additions to function testRotatedScreenConfig.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14364
To: gladhorn, #plasma, romangg
Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180727/b84852cf/attachment.html>
More information about the Plasma-devel
mailing list