D14422: Add edid converter

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> edid_converter.cpp:27
> +
> +class EdidHelper {
> +public:

Why do you need EdidHelper class? Would be better to have just functions.

> edid_converter.cpp:98
> +        return helper.parseFile(parser.value(binFileOption), EdidHelper::Type::Binary);
> +    } else if (parser.isSet(hexFileOption)) {
> +        return helper.parseFile(parser.value(hexFileOption), EdidHelper::Type::Hex);

It would be better to not use else if after return statement, IMHO.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D14422

To: gladhorn, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180727/6baf3461/attachment.html>