D14339: Remove confusing icons from rotation combobox
Frederik Gladhorn
noreply at phabricator.kde.org
Thu Jul 26 10:30:49 BST 2018
gladhorn added a comment.
In D14339#297849 <https://phabricator.kde.org/D14339#297849>, @ngraham wrote:
> Looks nice!
>
> I would approve of using radio buttons or four actual inline buttons instead of a combobox.
>
> Also +1 on "No Rotation" instead of "Normal", and for doing that in another patch.
So will you approve this? I can make a change for the label renaming and then we can still discuss splitting it into buttons/radio/whatever :)
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14339
To: gladhorn, #plasma, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180726/26d246d7/attachment.html>
More information about the Plasma-devel
mailing list