D14387: Optimise setting up the palette

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Jul 26 02:57:02 BST 2018


apol created this revision.
apol added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  For every setBrush/setColor we're initialising a new QBrush instance that
  allocates some space in memory. At the moment we were creating and destroying
  QBrush instances like crazy, this check aloen saves 23K calls only starting
  Discover.

TEST PLAN
  Tried with Discover, KAlgebra and Kirgami Gallery

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14387

AFFECTED FILES
  src/libkirigami/platformtheme.cpp

To: apol, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180726/4e19188b/attachment-0001.html>


More information about the Plasma-devel mailing list