D14350: Make sure for loop does not detach
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Jul 25 10:39:37 BST 2018
broulik added inline comments.
INLINE COMMENTS
> config.cpp:371
> dbg << "KScreen::Config(";
> - for (const auto output : config->outputs()) {
> + for (const auto &output : config->outputs()) {
> if (output->isConnected()) {
This still calls `config->outputs().begin()` and might detach, wouldn't it?
`qAsConst` also doesn't work for return value of a method call, so looks like you're gonna have to store it in a `const` variable first
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D14350
To: gladhorn, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180725/960d2536/attachment.html>
More information about the Plasma-devel
mailing list