D14326: Fix layout of resolution selection

Nathaniel Graham noreply at phabricator.kde.org
Tue Jul 24 14:08:22 BST 2018


ngraham added a comment.


  In D14326#296957 <https://phabricator.kde.org/D14326#296957>, @gladhorn wrote:
  
  > In D14326#296857 <https://phabricator.kde.org/D14326#296857>, @broulik wrote:
  >
  > > The slider case after looks misaligned here now. I think you should set margins to zero only for the ComboBox case where there is only that single widget?
  > >  F6134444: Screenshot_20180724_122521.png <https://phabricator.kde.org/F6134444>
  >
  >
  > I disagree, before the 720x400 in your example would have double spacing and not be alined with the checkbox above or combo below. It also had extra space on the right for no good reason. Why should it have extra spacing?
  
  
  However we do it, in the above screenshot, the slider's label should be visually top-aligned so that it lines up with the resolution text on top.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14326

To: gladhorn, #plasma, #vdg
Cc: ngraham, broulik, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180724/16b174f9/attachment.html>


More information about the Plasma-devel mailing list