D14264: Disconnect decoration button requestHover tooltip on decoration destuction

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Decoration is destroyed at some point before DecorationButton, as seen
  by the existing use of QPointer for holding the Decoration.
  Use of a weak pointer without guarding seems wrong.
  
  Every other connect (DecorationButton::Private::init) that proxies to
  the decorationimplementation in kwin guards against this by setting the
  connect lifespan to match decoration. This one connect was out of sync.
  
  BUG: 396723
  CCBUG: 396729

TEST PLAN
  Ran kwin.
  Checked I still had tooltips
  Didn't try to reproduce the original crash

REPOSITORY
  R129 Window Decoration Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14264

AFFECTED FILES
  src/decorationbutton.cpp

To: davidedmundson, #kwin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180721/6d6c5295/attachment.html>