D14143: Make the action selector OSD independent of the other OSDs

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> osd.cpp:125
> +        }
> +        m_osdActionSelector = new KDeclarative::QmlObject(this);
> +        m_osdActionSelector->setSource(QUrl::fromLocalFile(osdPath));

Should we use `QmlObjectSharedEngine` here? (could be done separately later)

> osd.cpp:139
> +    }
> +    Q_ASSERT(m_osdActionSelector);
> +    if (auto *rootObject = m_osdActionSelector->rootObject()) {

This assert can never be hit, you *always* create the object or return early and never end up here

> OsdSelector.qml:31
> +    type: PlasmaCore.Dialog.Normal
> +    visible: true
> +    property string infoText

Why initially visible?

> OsdSelector.qml:117
> +        Component.onCompleted: print("OsdSelector loaded...");
> +        Keys.onEscapePressed: clicked("dialog-cancel")
>      }

This looks unrelated to this particular patch ("In follow up changes, the keyboard handling will be added.")

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14143

To: gladhorn, #plasma, davidedmundson
Cc: broulik, davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180718/b04d42a0/attachment.html>