D14165: Handle keyboard in action selector OSD

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Jul 17 10:41:37 BST 2018


broulik added inline comments.

INLINE COMMENTS

> OsdSelector.qml:136
>          Keys.onEscapePressed: clicked("dialog-cancel")
> +        Keys.onReturnPressed: {
> +            clicked(buttonRow.checkedButton.action)

Also do `Keys.onEnterPressed` so that enter on numpad works

> OsdSelector.qml:148
> +                // check for checked property, the repeater is also a child and must be skipped
> +                if (event.key === Qt.Key_Left) {
> +                    do {

Make sure you take into account right-to-left languages (not sure if the layout mirrors then but it should, check by running the app with `-reverse` argument)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14165

To: gladhorn, #plasma
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180717/0258800f/attachment-0001.html>


More information about the Plasma-devel mailing list