D14174: Fix blur behind folderview context menus

David Edmundson noreply at phabricator.kde.org
Mon Jul 16 23:52:05 BST 2018


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Breeze has
  
  if (!(widget->testAttribute(Qt::WA_WState_Created) ||
  widget->internalWinId()))
  
    KWindowSystem::blur(widget->winId(), ...)
  
  which makes sense as the style should not be creating surfaces in polish
  and I don't want to remove it.
  
  This is problematic with QMenu::polish which has a subtle behavioural
  change compared to QMenu::exec in that it calls ensurePolish before
  creating the surface.
  
  Plasma::ContainmentInterface accidentally has this workaround already
  for parent window setting.
  
  BUG: 395262

TEST PLAN
  Right clicked on desktop icon
  Looked amazing

REPOSITORY
  R119 Plasma Desktop

BRANCH
  davidedmundson/kcm_clock_qml

REVISION DETAIL
  https://phabricator.kde.org/D14174

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180716/5bd31e04/attachment.html>


More information about the Plasma-devel mailing list