D14147: Port from GConf to GSettings

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:54
> +    set(USE_GCONF FALSE)
> +endif()
>  

Those two options (gconf, gsettings) should be mutually exclusive.

> Advanced.qml:76
>              onCheckedChanged: moduleManager.combineSinks = checked;
> -            enabled: moduleManager.loadedModules.indexOf("module-gconf") != -1
>              visible: moduleManager.settingsSupported

This should still check for "module-gconf" or "module-gsettings" being loaded in pulseaudio.

The way you changed it is that it will just completely hide those options if appropriate module is not loaded in pulseaudio without any indication to user what is wrong.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: rikmills, broulik, asturmlechner, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180716/5dfaea5f/attachment.html>