D14152: Remove ref from returned QString

Vlad Zagorodniy noreply at phabricator.kde.org
Mon Jul 16 08:52:31 BST 2018


zzag added inline comments.

INLINE COMMENTS

> osd.cpp:58
>  
> -    const QString &osdPath = QStandardPaths::locate(QStandardPaths::QStandardPaths::GenericDataLocation, QStringLiteral("kded_kscreen/qml/Osd.qml"));
> +    QString osdPath = QStandardPaths::locate(QStandardPaths::QStandardPaths::GenericDataLocation, QStringLiteral("kded_kscreen/qml/Osd.qml"));
>      if (osdPath.isEmpty()) {

Please keep `const`.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14152

To: gladhorn, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180716/a71ede33/attachment-0001.html>


More information about the Plasma-devel mailing list