D14143: Make the action selector OSD independent of the other OSDs

Vlad Zagorodniy noreply at phabricator.kde.org
Sun Jul 15 20:27:12 BST 2018


zzag added inline comments.

INLINE COMMENTS

> osd.cpp:120
> +    if (!m_osdActionSelector) {
> +        const QString &osdPath = QStandardPaths::locate(QStandardPaths::QStandardPaths::GenericDataLocation, QStringLiteral("kded_kscreen/qml/OsdSelector.qml"));
> +        if (osdPath.isEmpty()) {

Please delete reference. Compilers can eliminate unnecessary copying, so there is no need to do the lifetime expansion.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14143

To: gladhorn, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180715/56855d37/attachment.html>


More information about the Plasma-devel mailing list