D7087: Add "Copy Info" button to the About System KCM

gregormi noreply at phabricator.kde.org
Sun Jul 15 09:28:30 BST 2018


gregormi added inline comments.

INLINE COMMENTS

> rkflx wrote in Module.cpp:263
> Coming back to this after a month, I now wonder what `p` stands for, which might indicate that variable could get a better nameā€¦

p stands for labelPair: renaming is a good idea. Done.

> rkflx wrote in Module.cpp:260
> I'm afraid you missed the "hidden" part, so it shows up right in front of the distro logo ;)
> 
> Adding
> 
>   dummyDistroDescriptionLabel->hide();
> 
> where you are creating the label solves the issue for me.

dummy hide: Oh sorry, I should have seen that myself. Fixed it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180715/2de0818f/attachment.html>


More information about the Plasma-devel mailing list