D12804: Fix window frame rounding when scaling is used

[David Edmundson]

davidedmundson added a comment.


  > And in that function qreal newScale = screens()->scale(m_screen); gets the value from here: https://github.com/KDE/kwin/blob/master/screens.cpp#L114
  > You can see that this function just returns 1
  
  The method is virtual. It definitely is not always 1.
  
  > We already have a workaround in Breeze for this in some parts.
  
  That code you link to is not related to scaling at all. Its normalising a viewport on a canvas to always be between 1 and 20.
  
  ----
  
  However, there are some confusions so to back up a bit.
  
  On X11 kwin does not use scaling at all. There is the old horrible thing where things are bigger if fonts are bigger. 
  On wayland we do proper scaling, which is why it works correctly
  
  It's confusing when you say "when scaling is used" as you're actually referring to when we're not scaling - and doing the legacy thing.
  
  I'm only the maintainer of when scaling is used. I don't like the other mode existing as it means we have two competing scaling systems at once which super complicates my stuff..but as a patch for that mode it does look kinda right.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12804

To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson
Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180713/16cb1ca8/attachment-0001.html>