D14079: [Folder View] Create rename editor on demand

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Creating a `TextArea` is surprisingly costly.

TEST PLAN
  - Renaming files via context menu and F2 still works
  - Text field is properly placed
  - Hitting escape cancels rename as before
  - Hitting return or clicking outside commits rename like before
  - Keyboard navigation within the text field (Home, End, Shift select etc) works fine
  - Delegate label still hides properly while renaming

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14079

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180712/319e4bce/attachment.html>