D14060: Clean up string casts

Anthony Fieroni noreply at phabricator.kde.org
Thu Jul 12 07:52:18 BST 2018


anthonyfieroni added inline comments.

INLINE COMMENTS

> parser.cpp:145
> +    const QByteArray type = map[QStringLiteral("type")].toByteArray().toUpper();
>      if (type.contains("LVDS") || type.contains("EDP") || type.contains("IDP") || type.contains("7")) {
>          output->setType(Output::Panel);

It should be QLatin1String on contains?

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14060

To: gladhorn, #plasma, davidedmundson
Cc: anthonyfieroni, broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180712/e20cdf11/attachment.html>


More information about the Plasma-devel mailing list