D14060: Clean up string casts

[Frederik Gladhorn]

gladhorn marked 3 inline comments as done.
gladhorn added inline comments.

INLINE COMMENTS

> broulik wrote in testkwaylandbackend.cpp:88
> Why `true`?

Indeed, that makes no sense.

> broulik wrote in testlog.cpp:52
> I thought when concatenating the advantage of `QStringLiteral` don't cut it since you already have a string so should be `QLatin1String` instead?

You are right.

> broulik wrote in testqscreenbackend.cpp:174
> Could use initializer list

I feel the change is big enough as it is :)

> broulik wrote in parser.cpp:187
> `QLatin1String`?

My understanding is that since it's a QMap<QString, ..> all things will be converted to QString in any case.

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14060

To: gladhorn, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180712/297041a5/attachment-0001.html>