D12278: WIP: [Colors KCM] Port to new design

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> colors.cpp:313
> +    QStringList colorItemList;
> +    colorItemList << "BackgroundNormal"
> +                  << "BackgroundAlternate"

Can you use an initializer_list here and elsewhere?
Also QStringLiteral?

See https://www.angrycane.com.br/en/2018/06/19/speeding-up-cornercases/ for a comparison

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: nicolasfella, mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180711/4ae9ae1c/attachment.html>