D14024: Move KCM to UI file

Vlad Zagorodniy noreply at phabricator.kde.org
Wed Jul 11 16:30:19 BST 2018


zzag added inline comments.

INLINE COMMENTS

> widget.h:46-48
> +namespace Ui {
> +    class KScreenWidget;
> +}

Coding style nitpick:

  namespace Ui
  {
  class KScreenWidget;
  }

> widget.h:96
>    private:
> +    Ui::KScreenWidget *ui;
>      QMLScreen *mScreen = nullptr;

Naming nitpick: mUi

REPOSITORY
  R104 KScreen

BRANCH
  gladhorn/ui

REVISION DETAIL
  https://phabricator.kde.org/D14024

To: gladhorn, #plasma, sebas, davidedmundson
Cc: zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180711/9bcb58e7/attachment-0001.html>


More information about the Plasma-devel mailing list