D14044: Simplify getting edid in xrandr backend

Vlad Zagorodniy noreply at phabricator.kde.org
Wed Jul 11 11:49:40 BST 2018


zzag added inline comments.

INLINE COMMENTS

> xrandr.cpp:273
>          if (len % 128 == 0) {
> -            return result;
> -        } else {
> -            len = 0;
> -            delete[] result;
> +            edid = QByteArray((char *) result, len);
>          }

reinterpret_cast<char*>(result)

> xrandr.cpp:275
>          }
> +        delete[] result;
>      }

It would be great to use QScopedPointer, but that would be unrelated change, I guess.

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14044

To: gladhorn, #plasma, davidedmundson
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180711/3374f422/attachment.html>


More information about the Plasma-devel mailing list