D14031: Move ECM & Co. macro includes before finding Qt & KF
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue Jul 10 18:16:31 BST 2018
kossebau created this revision.
kossebau added reviewers: gladhorn, sebas, romangg.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.
REVISION SUMMARY
For consistency with other Plasma repos, but also to ensure the ECM
logic for supporting uninstalled unit tests is properly triggered
See
https://api.kde.org/ecm/kde-module/KDECMakeSettings.html#build-settings
Including KDECMakeSettings only after finding KF5CoreAddons and the
implicit loading of KF5PlasmaMacros/KF5PackageMacros resets the
ECM_GLOBAL_FIND_VERSION variable to the min ECM value 1.6.0 currently
used by those macro files, thus below the trigger value 5.38
TEST PLAN
Still builds and installs as before.
REPOSITORY
R104 KScreen
BRANCH
movemoduleincludestofront
REVISION DETAIL
https://phabricator.kde.org/D14031
AFFECTED FILES
CMakeLists.txt
To: kossebau, gladhorn, sebas, romangg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180710/982b38cd/attachment.html>
More information about the Plasma-devel
mailing list