D14023: Make Primary Combo a regular QComboBox

Frederik Gladhorn noreply at phabricator.kde.org
Tue Jul 10 12:09:24 BST 2018


gladhorn added a comment.


  Need to remove debug statements.

INLINE COMMENTS

> widget.cpp:171
> +
> +    qDebug() << Q_FUNC_INFO;
> +    Q_FOREACH (const KScreen::OutputPtr &output, mConfig->outputs()) {

Left over debug statement. Remove.

> widget.cpp:508
> +{
> +    qDebug() << Q_FUNC_INFO << index;
> +    if (!mConfig) {

remove

> widget.cpp:524
> +{
> +    qDebug() << Q_FUNC_INFO << output;
> +    Q_ASSERT(mConfig);

remove

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14023

To: gladhorn, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180710/32a0ff71/attachment.html>


More information about the Plasma-devel mailing list