D13999: [Kicker System Entry] Remove KDisplayManager global static

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Jul 9 10:30:15 BST 2018


broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It is only used in one place and cached, so no need for a global static that is created as soon as the plugin is loaded.

TEST PLAN
  No longer get a `KDisplayManager` instance on plasmashell startup with Kickoff, only when going to the Leave tab now. Tab still works.
  Kicker creates the model right away and still works.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13999

AFFECTED FILES
  applets/kicker/plugin/systementry.cpp
  applets/kicker/plugin/systementry.h

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180709/3fc251dc/attachment-0001.html>


More information about the Plasma-devel mailing list