D13881: oxygen-demo : add KMessage preview

René J.V. Bertin noreply at phabricator.kde.org
Wed Jul 4 18:59:46 BST 2018


rjvbb updated this revision to Diff 37155.
rjvbb added a comment.


  Updated as (hopefully) requested.
  
  I've left the property change event filter, for builds against older than 5.48.0 (or whatever version D13884 <https://phabricator.kde.org/D13884> will appear in).
  
  There is one side-effect that will exist with older frameworks and not with D13884 <https://phabricator.kde.org/D13884> in place: messages are recreated so will reappear if you've closed them. The easy way to prevent that would be to disable the close button, should I do that or do we not care about this? I can't say I'll lay awake about the detail...

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13881?vs=37137&id=37155

REVISION DETAIL
  https://phabricator.kde.org/D13881

AFFECTED FILES
  kstyle/demo/oxygenframedemowidget.cpp
  kstyle/demo/oxygenframedemowidget.h
  kstyle/demo/ui/oxygenframedemowidget.ui

To: rjvbb, hpereiradacosta
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180704/5892fef7/attachment-0001.html>


More information about the Plasma-devel mailing list