D13871: Make TestInProcess skip out-of-process tests if D-Bus service uninstalled

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Jul 3 18:23:01 BST 2018


kossebau created this revision.
kossebau added reviewers: dfaure, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  With the movement to support running unittests pre-installation and KDE CI
  having adapted to that for some build setups, this currently breaks tests
  which rely on subject-under-test D-Bus services being auto-started from
  D-Bus service files, given the D-Bus daemon does not see the uninstalled
  ones.
  
  One solution might be to catch that situation and do the start of the D-Bus
  service ourselves, but I failed to get this done quickly. So as intermediate
  solution, to at least have the in-process tests no longer being covered by
  the out-of-process ones failing, this patch will just skip the
  out-of-process tests if the D-Bus service could not be started.
  That follows the current behaviour of e.g. the KGlobalShortcutTest from
  KF5's kglobalaccel.

TEST PLAN
  TestInProcess no longer fails if the org.kde.KScreen D-Bus service cannot be
  autostarted.

REPOSITORY
  R110 KScreen Library

BRANCH
  makeTestSkipDBusTettsIfNotFound

REVISION DETAIL
  https://phabricator.kde.org/D13871

AFFECTED FILES
  autotests/testinprocess.cpp

To: kossebau, dfaure, sebas
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180703/d70e7e21/attachment-0001.html>


More information about the Plasma-devel mailing list