D13864: [Splash Screen KCM] Fix "no thumbnail" icon for "None"
Kai Uwe Broulik
noreply at phabricator.kde.org
Tue Jul 3 09:17:40 BST 2018
broulik created this revision.
broulik added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
In JavaScript `undefined` does not convert to empty string, so `undefined != ""` is always `true`.
The role isn't added to the `QStandardItemModel` for "None", so it is `undefined` (null `QVariant`) as far as QML is concerned.
TEST PLAN
5.13
"None" has the "no thumbnail available" icon now
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D13864
AFFECTED FILES
kcms/ksplash/package/contents/ui/main.qml
To: broulik, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180703/ce743b3d/attachment-0001.html>
More information about the Plasma-devel
mailing list