D13856: Work around KActivitiesStats' ResultsModel emitting wrong moves

Eike Hein noreply at phabricator.kde.org
Mon Jul 2 19:40:23 BST 2018


hein created this revision.
hein added reviewers: davidedmundson, mart.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Works around bug 396102 at negligible performance cost, in a way
  that won't break when KActivitiesStats gets fixed.
  
  Rationale:
  
  - I don't have time to fix KActivitiesStats.
  - The maintainer of KActivitiesStats may not be available for a fix.
  - There's an installed base of Plasma LTS which will not update KF5.
  
  As a bonus, this fixes a crash when refresh() would have ever been
  called during normal operation: The InvalidAppsFilterProxy and
  GroupSortProxy models were creating circular parent-child relation-
  ships by setting themselves as parents of their parent objects.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13856

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h

To: hein, davidedmundson, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180702/c0b3edb5/attachment.html>


More information about the Plasma-devel mailing list