D13853: Fix setting primary connector if primary output changed

[Robert Hoffmann]

hoffmannrobert created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  If a user logged in with one screen connected plugs in
  a second screen, which becomes the new primary screen,
  this screen would stay black or behave weird.
  
  Unplugging the screen again would mess up plasmashell.
  
  Added to ScreenPool::setPrimaryConnector():
  In the case primary output changed m_idForConnector
  doesn't contain the new primary, so a screen mapping
  is created for it.

TEST PLAN
  Testing on virtualbox or vmware player seems impossible, because
  these don't allow disabling the first display (VGA-1) and booting
  with the second (VGA-2) only.
  
  1. Boot machine with one screen connected to HDMI-3 (primary output).
  2. Log in
  3. Plug in second screen to HDMI-2:
  
  > primary output changes from HDMI-3 to HDMI-2
  ==============================================
  
  4. OSD appears: extend to right
  
  > Without this patch, the new screen (HDMI-2) would stay blank.
  ===============================================================
  
  > With this patch applied, the screen content moves to the new
  ==============================================================
  
    second screen.
  
  5. Unplug second screen (HDMI-2)
  
  > Without this patch, the background would get black, control panel
  ===================================================================
  
    would disappear, could only be restored by restart of plasmashell
  
  > With this patch applied, screen content moves to the right and
  ================================================================
  
    works

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13853

AFFECTED FILES
  shell/screenpool.cpp

To: hoffmannrobert
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180702/5ef398c2/attachment.html>