D13845: Fix Enhanced Media Controls disabled state
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Jul 2 11:17:18 BST 2018
broulik created this revision.
broulik added a reviewer: davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
When this code ran, settings weren't loaded yet, so the checkbox was always disabled on opening settings.
TEST PLAN
Opened settings with media controls enabled, enhanced checkbox was enabled.
Opened settings with media controls disabled, enhanced checkbox was disabled.
Settings still seem to work fine
Also ported to `querySelector` instead of `querySelectorAll[0]`
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D13845
AFFECTED FILES
extension/options.js
To: broulik, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180702/6f8d6288/attachment.html>
More information about the Plasma-devel
mailing list