D10217: Choose source with a combobox, but only on the desktop view

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Here I am again, hawking my combobox... :)
  
  This patch uses a combobox to select the source, but only for the desktop view. People are always complaining that Discover's desktop view doesn't feel like a desktop app, and using a desktop-metaphor UI element here would help the situation, I believe.
  
  On mobile, the UI is unchanged, and we show the overlay, which has always felt more mobile-like anyway. It's more at home on that view.
  
  When there is only a single source, we show a simple label for both desktop and mobile.

TEST PLAN
  Tested in KDE Neon. Source switching still works for all views and apps.
  
  Desktop view, single source:
  
  Desktop view, multiple sources:
  
  Desktop view, source chooser in action:
  
  Mobile view, single source:
  
  Mobile view, multiple sources:
  
  Mobile view, source chooser in action:

REPOSITORY
  R134 Discover Software Store

BRANCH
  combobox-on-desktop

REVISION DETAIL
  https://phabricator.kde.org/D10217

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, apol, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180131/6120e13e/attachment.html>