D10197: Fix krunner's alt+f2 on wayland

David Edmundson noreply at phabricator.kde.org
Wed Jan 31 00:21:15 UTC 2018


davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  For context, krunner inherits from Dialog. 
  Dialog does all this stuff.  Duplicating it here is wrong.
  
  Must have been ported first or something.

INLINE COMMENTS

> view.cpp:194-200
>      bool setState = event->type() == QEvent::Show;
>      if (event->type() == QEvent::PlatformSurface) {
>          setState = (static_cast<QPlatformSurfaceEvent*>(event)->surfaceEventType() == QPlatformSurfaceEvent::SurfaceCreated);
>      }
>      if (setState) {
>          KWindowSystem::setState(winId(), NET::SkipTaskbar | NET::SkipPager);
>      }

This relates to the QXcbWindow comment that you removed, can you leave it.

(I /think/ you can remove this code, it relates to David Rosca's patch that landed ages ago. Check first though)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10197

To: apol, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180131/7d95af47/attachment.html>


More information about the Plasma-devel mailing list